Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/dom export flat #5085

Merged
merged 42 commits into from
Aug 29, 2024
Merged

feature/dom export flat #5085

merged 42 commits into from
Aug 29, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Aug 2, 2024 •
edited by andrueastman
Loading

fixes #4628
fixes #4627

Exported files

  1. dotnet - https://raw.githubusercontent.com/microsoftgraph/msgraph-sdk-dotnet/kiota/v1.0/pipelinebuild/160559/src/Microsoft.Graph/Generated/kiota-dom-export.txt
  2. java - https://raw.githubusercontent.com/microsoftgraph/msgraph-sdk-java/v1.0/pipelinebuild/160559/src/main/java/com/microsoft/graph/generated/kiota-dom-export.txt
  3. go - https://github.com/microsoftgraph/msgraph-sdk-go/blob/v1.0/pipelinebuild/160559/kiota-dom-export.txt
  4. ts - https://raw.githubusercontent.com/microsoftgraph/msgraph-sdk-typescript/v1.0/pipelinebuild/160559/packages/kiota-dom-export.txt
  5. php - https://github.com/microsoftgraph/msgraph-sdk-php/blob/kiota/v1.0/pipelinebuild/160559/src/Generated/kiota-dom-export.txt
  6. python - https://github.com/microsoftgraph/msgraph-sdk-python/blob/v1.0/pipelinebuild/160559/msgraph/generated/kiota-dom-export.txt

baywet added 13 commits August 2, 2024 13:47
@baywet
chore: adds a task to reset sample locks when generating
26a7183 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: missing parent for code type
51cd7f0
@baywet
feat: base infrastructure for dom export
9ac2339
@baywet
fix: adds interface for accessibility elements
bea1c09 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat: early prortotype of linear export
f7226c0 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: property custom types
3b7257e 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat: adds indexer support
7a3d261 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat: adds support for enums
8d9816b 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat: adds support for inheritance and implement
7b10f85 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat: adds support for optional and defaulted parameters
bae6835 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: parameters separation to support generic types parsing
45397fe 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat: enables public API export service behind a flag
570b508 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: comment removal
3720261 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet self-assigned this Aug 2, 2024
@baywet baywet mentioned this pull request Aug 2, 2024
Merged
baywet and others added 13 commits August 16, 2024 13:13
@baywet
Merge branch 'main' into feature/dom-export-flat
486e521
Resolve PR comment
4a1635c
golang: ensure elements in code files have the namespace element extr…
4186211 
…acted.
Merge remote-tracking branch 'origin/main' into feature/dom-export-flat
1a61fc9
fix: TS does not generate getters and setters.
4dcf5e6 
This is making properties not show up in export as the are set as private by adding of the unused dom elements.

In general TS export is smaller that C# as it has
- no constructors
- no generated derived requestConfiuration classes.
- no withUrl method.
@andrueastman
Merge branch 'main' into feature/dom-export-flat
a6b0bb7
fixes PHP generation due to broken tree.
a9d9778
Merge remote-tracking branch 'origin/main' into feature/dom-export-flat
339fd36
adds validation tests.
0121012
Add changelog entry
8d55991
Merge remote-tracking branch 'origin/main' into feature/dom-export-flat
467df9b
Merge remote-tracking branch 'origin/main' into feature/dom-export-flat
8695f33
@andrueastman
Merge branch 'main' into feature/dom-export-flat
2f1aa47
@andrueastman andrueastman mentioned this pull request Aug 22, 2024
Merged
@andrueastman andrueastman marked this pull request as ready for review August 23, 2024 11:59
@andrueastman andrueastman requested a review from a team as a code owner August 23, 2024 11:59
@andrueastman andrueastman self-assigned this Aug 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Ndiritu
Ndiritu reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Ndiritu Ndiritu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from analysing the output files:

  • For PHP, the array type hint added to the PHPDoc provides meaningful type info.

@andrueastman andrueastman merged commit 07e6f1b into main Aug 29, 2024
209 checks passed
@andrueastman andrueastman deleted the feature/dom-export-flat branch August 29, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@Ndiritu Ndiritu Ndiritu approved these changes

@calebkiage calebkiage Awaiting requested review from calebkiage

Assignees

@andrueastman andrueastman

@baywet baywet

Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
4 participants
@baywet @calebkiage @andrueastman @Ndiritu